Lookahead decoding eager implementation #12491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveknayakatmeta
requested review from
cccclai,
jackzhxng,
lucylq and
metascroy
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12491
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 737594d with merge base a4ac131 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
This PR needs a
|
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 15, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
0b1f86d to
7002d11
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 15, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
2 times, most recently
from
6dc214e to
56bae76
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 15, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu Differential Revision: D78323399
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
56bae76 to
3ea3404
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch#12491 Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu Differential Revision: D78323399
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch#12491 Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
3ea3404 to
e6b28df
Compare
billmguo
approved these changes
Jul 15, 2025
|
@viveknayakatmeta has imported this pull request. If you are a Meta employee, you can view this in D78323399. |
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
aa78ad1 to
a2e1aa2
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: billmguo Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Differential Revision: D78323399 Pulled By: viveknayakatmeta
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
a2e1aa2 to
088fec3
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: billmguo Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Differential Revision: D78323399 Pulled By: viveknayakatmeta
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: billmguo Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Differential Revision: D78323399 Pulled By: viveknayakatmeta
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
088fec3 to
cb1c1f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
cb1c1f8 to
ba7be95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
ba7be95 to
28cb813
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
28cb813 to
9d60d35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
9d60d35 to
72a7384
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
d4bed3c to
26f7494
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
15868c1 to
d4bed3c
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
Summary: Pull Request resolved: pytorch#12491 Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
|
This pull request was exported from Phabricator. Differential Revision: D78323399 |
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
26f7494 to
737594d
Compare
viveknayakatmeta
added a commit
to viveknayakatmeta/executorch
that referenced
this pull request
Jul 16, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu, billmguo Differential Revision: D78323399
viveknayakatmeta
force-pushed
the
export-D78323399
branch
from
72a7384 to
15868c1
Compare
lucylq
pushed a commit
that referenced
this pull request
Jul 17, 2025
Summary: Implement reference lookahead decoding for CoreML implementation. Reviewed By: sxu Differential Revision: D78323399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Implement reference lookahead decoding for CoreML implementation.
Reviewed By: sxu
Differential Revision: D78323399